Commands gone Wrong in PgcEdit

[peterk]

********** pre commands:
1 NOP
2 NOP
3 NOP
4 NOP
5 Set gprm(0) =(mov) gprm(5)
6 if ( gprm(0) != 0 ) then { Goto line 8 }
7 Set gprm(0) =(mov) 1
8 Set gprm(0) &=(and) 63
9 Set gprm(0) *=(mul) 1024
10 NOP
11 Set gprm(3) =(mov) 10
12 (SetHL_BTN) Set Highlighted Button =(mov) gprm(0)
13 Set gprm(1) =(mov) 0

********** post commands:
1 Set gprm(3) =(mov) 0
2 Set gprm(0) =(mov) sprm(8:Highlighted button number)
3 Set gprm(0) /=(div) 1024
4 if ( gprm(0) != 1 ) then { Goto line 8 }
5 Set gprm(4) =(mov) 266
6 (JumpSS) Jump to VMGM PGC 2
7 NOP
8 if ( gprm(0) != 2 ) then { Goto line 12 }
9 Set gprm(5) =(mov) 5
10 LinkPGCN PGC 17
11 NOP
12 if ( gprm(0) != 3 ) then { Goto line 16 }
13 Set gprm(5) =(mov) 1
14 LinkPGCN PGC 8
15 NOP
16 NOP
********** cell commands:

I have done some editing and now when playing it, it just goes into a loop. These Commands above are exactly the same for Before and After the mods. (except line 10 is now PGC15 and line 14 is PGC6). The sequence is as follows...

original dvd....
Post Commands 1, 2, 3, 4, 8, 12, 13, 14... then it goes to VTSM1 PGC8 the main menu. This is right.

modified dvd....
Post Commands 1, 2, 3, 4, 8, 9, 10... then it goes to LinkPGCN PGC15 and into an endless oblivion.

I can sort of follow what is happening but not why it goes to the wrong place. Set gprm is the same values as before/after isn't it?

[blutach]

Maybe restore your backup? (Ctrl-Alt-B)

To assist you, we need to know the status of the registers as you enter the PGC.

You can do a trace and see what has changed.

But anyway, it seems you have pressed button 2 (shouldn't be anything wrong with that). Find the correct PGC you need it to go to. Assuming none have been deleted, perhaps that is 17.

Regards

[peterk]

I don't know what these letters mean but on the working dvd commands line 8 says to goto line 12 if !=2, which it does, then line 12 is !=3 (obviously (gprm 0 is not that value therefore line 12 and 14 are executed next).

These are exactly the same for the modified dvd ie, line 8 is gprm (0) !=2, yet it goes to line 9 instruction instead of line 12 as it should.

How could you determine that button 2 is selected from any of the above?
The menu used to have 3 buttons, it now has 2 buttons. 1 was deleted using Menu Edit and Photoshop.

[blutach]

Meaning gprm(0) = 2

Button 2 was pressed because it executes command 9. The deletion of the button is probably the cause. You should always HIDE buttons, not delete them. In any event, unless you renumbered the buttons, it should have no effect.

Clearly, the button editing has got in the way. Essentially, whatever used to be button 3 is now button 2.

Try copying lines 13 and 14 to lines 9 and 10.

Test via trace and software player.

Next time, use PgcEdit to hide the unwanted button.



Regards

[peterk]

Thanks Blutach, you came thru again for me.
I can't copy lines 13 and 14 to lines 9 and 10 as PGC15 eventually calls up my 2 button menu. I took your other suggestion and Hid the unwanted button, previously I have been Deleting unwanted buttons and haven't had any problems until now. When a button is Deleted the button numbers are auto renumbered accordingly and thus caused my problem. Whereby, just to Hide a button then the button numbers are kept as they were originally and so fit in with the commands.

Isn't learning fun, thanks again.